Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with the Add/AddAssign impls for Cow<str> #37574

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Fix issues with the Add/AddAssign impls for Cow<str> #37574

merged 1 commit into from
Nov 6, 2016

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Nov 4, 2016

  • Correct the stability attributes.
  • Make Add and AddAssign actually behave the same.
  • Use String::with_capacity when allocating a new string.
  • Fix the tests.

@ollie27
Fix issues with the Add/AddAssign impls for Cow<str>
1e40c80 
* Correct the stability attributes.
* Make Add and AddAssign actually behave the same.
* Use String::with_capacity when allocating a new string.
* Fix the tests.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Nov 4, 2016

📌 Commit 1e40c80 has been approved by alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 4, 2016
@alexcrichton
Rollup merge of rust-lang#37574 - ollie27:cow_add, r=alexcrichton
5b1e617 
Fix issues with the Add/AddAssign impls for Cow<str>

* Correct the stability attributes.
* Make Add and AddAssign actually behave the same.
* Use String::with_capacity when allocating a new string.
* Fix the tests.
@alexcrichton alexcrichton mentioned this pull request Nov 4, 2016
Merged
bors added a commit that referenced this pull request Nov 5, 2016
@bors
Auto merge of #37597 - alexcrichton:rollup, r=alexcrichton
16d5330 
Rollup of 24 pull requests

- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 5, 2016
Rollup merge of rust-lang#37574 - ollie27:cow_add, r=alexcrichton
f6a65b9 
Fix issues with the Add/AddAssign impls for Cow<str>

* Correct the stability attributes.
* Make Add and AddAssign actually behave the same.
* Use String::with_capacity when allocating a new string.
* Fix the tests.
@sophiajt sophiajt mentioned this pull request Nov 5, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 5, 2016
@alexcrichton
Rollup merge of rust-lang#37574 - ollie27:cow_add, r=alexcrichton
638436e 
Fix issues with the Add/AddAssign impls for Cow<str>

* Correct the stability attributes.
* Make Add and AddAssign actually behave the same.
* Use String::with_capacity when allocating a new string.
* Fix the tests.
bors added a commit that referenced this pull request Nov 6, 2016
@bors
Auto merge of #37597 - alexcrichton:rollup, r=alexcrichton
3fc8304 
Rollup of 24 pull requests

- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
@bors bors merged commit 1e40c80 into rust-lang:master Nov 6, 2016
@ollie27 ollie27 deleted the cow_add branch November 6, 2016 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ollie27 @rust-highfive @alexcrichton @bors